Page MenuHomePhabricator

Remove blockFinished from BlockAssembler
ClosedPublic

Authored by schancel on Jul 25 2018, 01:11.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rABC9c6f4b94b4a1: Remove blockFinished from BlockAssembler
Summary

As per title, stop using spooky action at a distance

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
more-miner-nits
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2941
Build 3982: Bitcoin ABC Teamcity Staging
Build 3981: arc lint + arc unit

Event Timeline

schancel created this revision.Jul 25 2018, 01:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2018, 01:11
schancel updated this revision to Diff 4389.Jul 25 2018, 01:14

Fix accidentally removed code during rebase

schancel updated this revision to Diff 4390.Jul 25 2018, 01:43

Remove a missed reference

jasonbcox accepted this revision.Jul 25 2018, 02:03
This revision is now accepted and ready to land.Jul 25 2018, 02:03
schancel updated this revision to Diff 4392.Jul 25 2018, 02:08

Remove wild semicolon

schancel updated this revision to Diff 4393.Jul 25 2018, 02:18

Reword TestForBlockResult parameter to make it clearer

deadalnix requested changes to this revision.Jul 25 2018, 14:30
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/miner.cpp
302 ↗(On Diff #4393)

You should move this in the header.

643 ↗(On Diff #4393)

This clearly changes the semantic. You tested for a specific package to be added, but then never adds it. Also, if blockFinished is true, the thing continue to loop until iterator runs out.

This revision now requires changes to proceed.Jul 25 2018, 14:30
schancel updated this revision to Diff 4401.Jul 25 2018, 14:58

Fix nits

schancel updated this revision to Diff 4402.Jul 25 2018, 15:13

Address some more feedback

deadalnix accepted this revision.Jul 25 2018, 15:21
deadalnix added inline comments.
src/miner.h
128

You can probably declare this as a private local class in BlockAssembler, as the only function using it is private anyway.

130

TXCantFit ?

This revision is now accepted and ready to land.Jul 25 2018, 15:21
schancel updated this revision to Diff 4403.Jul 25 2018, 15:24

Fix a typo

schancel updated this revision to Diff 4404.Jul 25 2018, 15:41

Fix a few nits

This revision was automatically updated to reflect the committed changes.