Page MenuHomePhabricator

[ecash-lib] Add `SigHashType`
ClosedPublic

Authored by tobias_ruck on Apr 11 2024, 23:51.

Details

Reviewers
bytesofman
PiRK
Group Reviewers
Restricted Project
Commits
rABC37fd74385bc0: [ecash-lib] Add `SigHashType`
Summary

SigHashType is a class that represents all possible sighash types that can be used to sign a tx input, for both legacy (before UAHF) and BIP143 signatures.

Test Plan

npm run test && npm run build

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-lib-sighashtype
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28502
Build 56545: Build Diffecash-lib-tests
Build 56544: arc lint + arc unit

Event Timeline

tobias_ruck updated this revision to Diff 47067.

remove unnecessary imports

PiRK added a subscriber: PiRK.

Note that the BIP143 naming is not used in the c++ code, the FORKID name is used instead. That got me confused for a while.

Screenshot from 2024-04-14 09-19-47.png (506×681 px, 74 KB)

This revision is now accepted and ready to land.Apr 14 2024, 07:20
This revision was automatically updated to reflect the committed changes.