Page MenuHomePhabricator

[Cashtab] Do not specify change address in getSlpGenesisTargetOutput
ClosedPublic

Authored by bytesofman on Apr 12 2024, 12:52.

Details

Summary

Standard API in ecash-coinselect is to create change outputs with no specified address. So, Cashtab already handles these outputs by adding Cashtab's expected change address, which is the Path1899 address.

We should not be hardcoding this into only 1 of our many specialty tx building functions. It should follow this existing standard.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
improve-gen-fn
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28510
Build 56561: Build Diffcashtab-tests
Build 56560: arc lint + arc unit