Differential D15981
[Cashtab] Patch minify menu flicker Authored by bytesofman on Apr 15 2024, 19:41.
Details
T3508 Still seeing some break points where the menu will flicker between minified and unminified, based on scrollY changing to and from opposite sides of the threshhold during browser-calculated re-renders. Update the logic so that we do not switch back to the "full" menu until we scroll further up. npm test, npm start try to recreate the issue
Diff Detail
Event TimelineComment Actions The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below. Comment Actions could you show an example? but also, imo the flickering is much worse than the extra scrolling. The extra scrolling situation still needs another patch anyway to deal with the size of other non-footer elements. Comment Actions See below. But yes agree with this being better than the flickering issue if it comes down to a tradeoff. Comment Actions ok. I think this should be fixed in isolation after this diff. Since this change needs to get in to stop the prod flickering, and the scroll minimization is already imperfect -- imo need to get this in before figuring out the scroll issue. 2 variables i want to mess with in addressing the empty content scrolling are
and I don't think those should be addressed in this bug-fix. |