[Cashtab] Patch minify menu flicker
ClosedPublic
Actions

Authored by bytesofman on Mon, Apr 15, 19:41.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC5431fc672d7a: [Cashtab] Patch minify menu flicker

Summary

T3508

Still seeing some break points where the menu will flicker between minified and unminified, based on scrollY changing to and from opposite sides of the threshhold during browser-calculated re-renders.

Update the logic so that we do not switch back to the "full" menu until we scroll further up.

Test Plan

npm test, npm start try to recreate the issue

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Mon, Apr 15, 19:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Apr 15, 19:41

back out unrelated changes

bytesofman published this revision for review.Mon, Apr 15, 19:44

Harbormaster completed remote builds in B28575: Diff 47169.Mon, Apr 15, 19:56

Harbormaster completed remote builds in B28576: Diff 47170.

The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below.

This revision now requires changes to proceed.Mon, Apr 15, 23:50

In D15981#361647, @emack wrote:

The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below.

could you show an example?

but also, imo the flickering is much worse than the extra scrolling. The extra scrolling situation still needs another patch anyway to deal with the size of other non-footer elements.

In D15981#361661, @bytesofman wrote:

In D15981#361647, @emack wrote:

The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below.

could you show an example?

but also, imo the flickering is much worse than the extra scrolling. The extra scrolling situation still needs another patch anyway to deal with the size of other non-footer elements.

See below. But yes agree with this being better than the flickering issue if it comes down to a tradeoff.

ok. I think this should be fixed in isolation after this diff. Since this change needs to get in to stop the prod flickering, and the scroll minimization is already imperfect -- imo need to get this in before figuring out the scroll issue.

2 variables i want to mess with in addressing the empty content scrolling are