Page MenuHomePhabricator

[Cashtab] Patch minify menu flicker
ClosedPublic

Authored by bytesofman on Apr 15 2024, 19:41.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC5431fc672d7a: [Cashtab] Patch minify menu flicker
Summary

T3508

Still seeing some break points where the menu will flicker between minified and unminified, based on scrollY changing to and from opposite sides of the threshhold during browser-calculated re-renders.

Update the logic so that we do not switch back to the "full" menu until we scroll further up.

Test Plan

npm test, npm start try to recreate the issue

Diff Detail

Repository
rABC Bitcoin ABC
Branch
flicker-fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28575
Build 56691: Build Diffcashtab-tests
Build 56690: arc lint + arc unit

Event Timeline

emack requested changes to this revision.Apr 15 2024, 23:50
emack added a subscriber: emack.

The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below.

This revision now requires changes to proceed.Apr 15 2024, 23:50

The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below.

could you show an example?

but also, imo the flickering is much worse than the extra scrolling. The extra scrolling situation still needs another patch anyway to deal with the size of other non-footer elements.

The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below.

could you show an example?

but also, imo the flickering is much worse than the extra scrolling. The extra scrolling situation still needs another patch anyway to deal with the size of other non-footer elements.

See below. But yes agree with this being better than the flickering issue if it comes down to a tradeoff.

ok. I think this should be fixed in isolation after this diff. Since this change needs to get in to stop the prod flickering, and the scroll minimization is already imperfect -- imo need to get this in before figuring out the scroll issue.

2 variables i want to mess with in addressing the empty content scrolling are

  • the inclusion / size of the cashtab logo
  • nav headers

and I don't think those should be addressed in this bug-fix.

This revision is now accepted and ready to land.Apr 16 2024, 01:18
This revision was automatically updated to reflect the committed changes.