T3461
Animated check mark when a tx is finalized. For now, this only happens when a block is finalized.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC0a2e431df777: [Cashtab] Add animation for avalanche finalized txs
npm test, review aesthetics
this diff is live at https://cashtab-local-dev.netlify.app/
on the test site (or with npm start), send yourself a tx. observe it shows inline loader in history and "confirming" + inline loader in tx panel when expanded. Wait for tx to confirm. Observe that the tx updates automatically to finalized (on the dev site, there are also dev logs for this).
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- avalanche-confirmation-check
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 28592 Build 56725: Build Diff cashtab-tests Build 56724: arc lint + arc unit
Event Timeline
Comment Actions
update icon, only save avalanche finalized chaintip, compare to chaintip in tx history to render txs as avalanche finalized
| cashtab/src/components/Home/Tx/__tests__/index.test.js | ||
|---|---|---|
| 173 | we do not test the avalanche finalization on every single tx. But we do pass the param to make sure there are no render errors. | |
| cashtab/src/slpv1/index.js | ||
| 521 | handled separately in D15990 need to implement here for test CI | |
| cashtab/src/wallet/useWallet.js | ||
| 148 | We do not need to get this in the update loop, esp now that we are handling the BLK_FINALIZED websocket event. Instead, we get it on app load and then update with the websocket. | |