Page MenuHomePhabricator

[Cashtab] Add animation for avalanche finalized txs
ClosedPublic

Authored by bytesofman on Apr 15 2024, 23:05.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC0a2e431df777: [Cashtab] Add animation for avalanche finalized txs
Summary

T3461

Animated check mark when a tx is finalized. For now, this only happens when a block is finalized.

Test Plan

npm test, review aesthetics

image.png (219×476 px, 22 KB)

image.png (256×490 px, 28 KB)

this diff is live at https://cashtab-local-dev.netlify.app/

on the test site (or with npm start), send yourself a tx. observe it shows inline loader in history and "confirming" + inline loader in tx panel when expanded. Wait for tx to confirm. Observe that the tx updates automatically to finalized (on the dev site, there are also dev logs for this).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

update icon, only save avalanche finalized chaintip, compare to chaintip in tx history to render txs as avalanche finalized

better rendering, show loader when not finalized, update tests

remove debug logs, better css org

bytesofman added inline comments.
cashtab/src/components/Home/Tx/__tests__/index.test.js
173 ↗(On Diff #47196)

we do not test the avalanche finalization on every single tx. But we do pass the param to make sure there are no render errors.

cashtab/src/slpv1/index.js
521 ↗(On Diff #47196)

handled separately in D15990

need to implement here for test CI

cashtab/src/wallet/useWallet.js
148 ↗(On Diff #47196)

We do not need to get this in the update loop, esp now that we are handling the BLK_FINALIZED websocket event.

Instead, we get it on app load and then update with the websocket.

bytesofman edited the test plan for this revision. (Show Details)

update tx history on block finalization if we have unconfirmed txs to update

better styling for small-width mobile devices

This revision is now accepted and ready to land.Apr 17 2024, 01:48