Page MenuHomePhabricator

[Cashtab Extension] Increase height to improve app->extension UX
ClosedPublic

Authored by emack on Apr 24 2024, 12:26.

Details

Summary

The recent additions of the cashtab message and opreturnraw toggles plus the output textarea have pushed the Send button to just beyond the existing dimensions, causing the users to scroll down to Send.

This diff increases the height to facilitate a smoother app->extension UX.

Current NOTIFICATION_HEIGHT @ 750

image.png (800×465 px, 61 KB)

New NOTIFICATION_HEIGHT @ 950

image.png (1×465 px, 77 KB)

Test Plan

Use an external app to trigger a BIP21 transaction to the extension and observe the Send button is in view without needing to scroll.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
extensionHeightIncrease
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28733
Build 57005: Build Diffcashtab-tests
Build 57004: arc lint + arc unit

Event Timeline

emack requested review of this revision.Apr 24 2024, 12:26

please do a patch version bump in extension/public/manifest.json before landing. Let me know when you land and I will submit to the chrome store.

"version": "3.35.0", to "version": "3.35.1",

This revision is now accepted and ready to land.Apr 24 2024, 13:01