Paths

Table of Contentst

Differential D16047

[Cashtab Extension] Increase height to improve app->extension UX
ClosedPublic
Actions

Authored by emack on Wed, Apr 24, 12:26.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC289e2698f0a7: [Cashtab Extension] Increase height to improve app->extension UX

Summary

The recent additions of the cashtab message and opreturnraw toggles plus the output textarea have pushed the Send button to just beyond the existing dimensions, causing the users to scroll down to Send.

This diff increases the height to facilitate a smoother app->extension UX.

Current NOTIFICATION_HEIGHT @ 750

New NOTIFICATION_HEIGHT @ 950

Test Plan

Use an external app to trigger a BIP21 transaction to the extension and observe the Send button is in view without needing to scroll.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

extensionHeightIncrease

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28733
Build 57005: Build Diff	cashtab-tests
Build 57004: arc lint + arc unit

Event Timeline

emack created this revision.Wed, Apr 24, 12:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 24, 12:26

emack requested review of this revision.Wed, Apr 24, 12:26

emack edited the summary of this revision. (Show Details)Wed, Apr 24, 12:29

Harbormaster completed remote builds in B28731: Diff 47396.Wed, Apr 24, 12:31

please do a patch version bump in extension/public/manifest.json before landing. Let me know when you land and I will submit to the chrome store.

"version": "3.35.0", to "version": "3.35.1",

This revision is now accepted and ready to land.Wed, Apr 24, 13:01

Move off master branch

Harbormaster completed remote builds in B28732: Diff 47398.Wed, Apr 24, 13:05

version bump

Harbormaster completed remote builds in B28733: Diff 47399.Wed, Apr 24, 13:19

Closed by commit rABC289e2698f0a7: [Cashtab Extension] Increase height to improve app->extension UX (authored by emack). · Explain WhyWed, Apr 24, 13:22

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC289e2698f0a7: [Cashtab Extension] Increase height to improve app->extension UX.

Revision Contents
Changeset List

Path

Size

cashtab/

extension/

public/

manifest.json

2 lines

src/

service_worker.js

2 lines

Diff 47399

View Options

cashtab/extension/public/manifest.json