[Cashtab] Use latest chronik-client
ClosedPublic
Actions

Authored by bytesofman on Apr 28 2024, 21:08.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC91020cd9d366: [Cashtab] Use latest chronik-client

Summary

Upgrade chronik-client so we get timeFirstSeen as a number and not a string

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Apr 28 2024, 21:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2024, 21:08

Harbormaster completed remote builds in B28781: Diff 47464.Apr 28 2024, 21:12

bytesofman published this revision for review.Apr 29 2024, 13:15

Upgrade chronik-client so we get timeFirstSeen as a number and not a string

Right now references to timeFirstSeen seems to already assume it's a number rather than a string. Is it currently being converted to number somewhere?

This revision now requires changes to proceed.Apr 29 2024, 14:34

In D16065#363763, @emack wrote:

Upgrade chronik-client so we get timeFirstSeen as a number and not a string

Right now references to timeFirstSeen seems to already assume it's a number rather than a string. Is it currently being converted to number somewhere?

it just happens to be working now due to javascript accidents, i.e.