Page MenuHomePhabricator
Differential D16097

Index: Use prune locks for blockfilterindex
ClosedPublic
Actions

Authored by PiRK on Thu, May 2, 12:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC958c08f85305: Index: Use prune locks for blockfilterindex
Summary

Prior to this change blocks could be pruned up to the last block before the blockfilterindex current best block.

This is a partial backport of core#21726, core#26215 and core#24410
https://github.com/bitcoin/bitcoin/pull/21726/commits/f08c9fb0c6a799e3cb75ca5f763a746471625beb
https://github.com/bitcoin/bitcoin/pull/26215/commits/8891949bdcb25093d3a6703ae8228c3c3687d3a4 (fixes a race introduced by previous commit)
https://github.com/bitcoin/bitcoin/pull/24410/commits/52b1939993771d0a8a718ca1667241872de8241a

Depends on D16096

Test Plan

cmake .. -GNinja -DBUILD_BITCOIN_CHAINSTATE=ON && ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Thu, May 2, 12:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, May 2, 12:26
PiRK requested review of this revision.Thu, May 2, 12:26
teamcity edited the summary of this revision. (Show Details)Thu, May 2, 12:26
PiRK edited the summary of this revision. (Show Details)Thu, May 2, 12:28
PiRK added a child revision: D16098: coinstats: Move hasher codepath to kernel/coinstats.Thu, May 2, 12:30
Harbormaster completed remote builds in B28854: Diff 47564.Thu, May 2, 13:33
PiRK updated this revision to Diff 47581.Fri, May 3, 06:42

add UpdatePruneLock function

PiRK added a comment.Fri, May 3, 06:44

@bot build-tsan

teamcity awarded a token.Fri, May 3, 06:44
Harbormaster completed remote builds in B28869: Diff 47581.Fri, May 3, 07:14
Fabien accepted this revision.Fri, May 3, 08:09
This revision is now accepted and ready to land.Fri, May 3, 08:09
Closed by commit rABC958c08f85305: Index: Use prune locks for blockfilterindex (authored by Fabian Jahr <fjahr@protonmail.com>, committed by PiRK). · Explain WhyFri, May 3, 08:34
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC958c08f85305: Index: Use prune locks for blockfilterindex.

Revision Contents
Changeset List

PathSize
src/
2 lines
index/
5 lines
39 lines
2 lines
2 lines
2 lines
node/
5 lines
6 lines
6 lines
test/
lint/
2 lines

Diff 47583

View Options

src/CMakeLists.txt

Loading...
View Options

src/index/base.h

Loading...
View Options

src/index/base.cpp

Loading...
View Options

src/index/blockfilterindex.h

Loading...
View Options

src/index/coinstatsindex.h

Loading...
View Options

src/index/txindex.h

Loading...
View Options

src/node/blockstorage.h

Loading...
View Options

src/node/blockstorage.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/lint/lint-circular-dependencies.sh

Loading...