Paths

Table of Contentst

Differential D16104

refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`
ClosedPublic
Actions

Authored by PiRK on May 3 2024, 13:26.

Tags

None

Subscribers

Tokens

"Haypence" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC22f5560fd2f6: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`

Summary

It is not obvious that CheckSequenceLocksAtTip() function can modify its LockPoints* lp parameter which leads to bugs such as https://github.com/bitcoin/bitcoin/pull/22677#discussion_r762040101 (bug avoided in D12441 by squashing the fix with the commit introducing it)

This is a backport of core#23897

Notes:

that this codebase has a single call site for CheckSequenceLocksAtTip in PreChecks. This is called via AcceptToMemoryPool in DisconnectedBlockTransactions::updateMempoolForReorg, so we don't have to deal with the code duplication in Core's Chainstate::MaybeUpdateMempoolForReorg function
this codebase no longer has the LockPoint::maxInputBlock computation code (see D15788)

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr26533

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28903
Build 57344: Build Diff	build-without-wallet · lint-circular-dependencies · build-diff · build-clang-tidy · build-clang
Build 57343: arc lint + arc unit

Event Timeline

PiRK created this revision.May 3 2024, 13:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2024, 13:26

teamcity edited the summary of this revision. (Show Details)May 3 2024, 13:32

PiRK published this revision for review.May 3 2024, 13:45

PiRK edited the summary of this revision. (Show Details)

use tx.GetId()

Harbormaster completed remote builds in B28875: Diff 47596.May 3 2024, 13:50

i think i need to remove some unused code

remove unneeded max_input_height computation in CalculateLockPointsAtTip

Harbormaster completed remote builds in B28879: Diff 47600.May 3 2024, 14:08

Harbormaster completed remote builds in B28880: Diff 47601.May 3 2024, 14:16

@bot build-ibd

src/validation.h
449–451 ↗	(On Diff #47601)	This comment makes no sense, you mixed it somehow

This revision now requires changes to proceed.May 6 2024, 08:01

teamcity awarded a token.May 6 2024, 08:01

fix doxygen comment for lock_points (remove duplicated part of a sentence from the coins_view doxygen comment from the previous function)

Fabien accepted this revision.May 6 2024, 11:33

This revision is now accepted and ready to land.May 6 2024, 11:33

This revision was landed with ongoing or failed builds.May 6 2024, 11:54

Closed by commit rABC22f5560fd2f6: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()` (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain Why

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC22f5560fd2f6: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`.

Revision Contents
Changeset List

Path

Size

src/

test/

miner_tests.cpp

7 lines

33 lines

104 lines

Diff 47628

src/test/miner_tests.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...