Paths

Table of Contentst

Differential D16143

refactor: Avoid CScriptCheck::swap
ClosedPublic
Actions

Authored by PiRK on May 13 2024, 06:49.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb3e09635eb70: refactor: Avoid CScriptCheck::swap

Summary

This is a partial backport of core#26479
https://github.com/bitcoin/bitcoin/pull/26749/commits/15209d97c6aad7d5c199fe007ad39b91c8ee6562
https://github.com/bitcoin/bitcoin/pull/26749/commits/06820032142a75cc3c5b832045058bc6f6f74786

The validation.cpp change was already done in D297

Test Plan

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28981
Build 57499: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57498: arc lint + arc unit

Event Timeline

PiRK created this revision.May 13 2024, 06:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2024, 06:49

PiRK requested review of this revision.May 13 2024, 06:49

teamcity edited the summary of this revision. (Show Details)May 13 2024, 06:49

PiRK added a child revision: D16144: refactor: Use move semantics in `CCheckQueue::Add`.May 13 2024, 06:50

Harbormaster completed remote builds in B28981: Diff 47738.May 13 2024, 07:13

Fabien added a subscriber: Fabien.May 13 2024, 13:46

Fabien added inline comments.

src/validation.h
498	Is this still useful ?

nvm it's in the stack

This revision is now accepted and ready to land.May 13 2024, 13:47

Closed by commit rABCb3e09635eb70: refactor: Avoid CScriptCheck::swap (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyMay 13 2024, 16:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb3e09635eb70: refactor: Avoid CScriptCheck::swap.

Revision Contents
Changeset List

Path

Size

src/

test/

transaction_tests.cpp

6 lines

validation.h

5 lines

Diff 47738

View Options

src/test/transaction_tests.cpp