Differential D16153

Add missing includes in assumptions.h and chainstate.cpp
ClosedPublic
Actions

Authored by PiRK on May 14 2024, 10:59.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc7e566a3fa1c: Add missing includes in assumptions.h and chainstate.cpp

Summary

The inclusion of this header should not depend on the inclusion of other
headers that include cstddef themselves.

This is a partial backport of core#27254
https://github.com/bitcoin/bitcoin/pull/27254/commits/106b46d9d25b5228ef009fbbe6f9a7ae35090d15
https://github.com/bitcoin/bitcoin/pull/27254/commits/b202b3dd6393b415fa68e18dc49c9431dc6b58b2

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 14 2024, 10:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2024, 10:59

PiRK requested review of this revision.May 14 2024, 10:59

teamcity edited the summary of this revision. (Show Details)May 14 2024, 10:59

PiRK added a child revision: D16154: refactor: Move fs.* to util/fs.*.May 14 2024, 11:01

Harbormaster completed remote builds in B28996: Diff 47765.May 14 2024, 11:27

Fabien accepted this revision.May 15 2024, 07:44

This revision is now accepted and ready to land.May 15 2024, 07:44

Closed by commit rABCc7e566a3fa1c: Add missing includes in assumptions.h and chainstate.cpp (authored by TheCharlatan <seb.kung@gmail.com>, committed by PiRK). · Explain WhyMay 16 2024, 08:30

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc7e566a3fa1c: Add missing includes in assumptions.h and chainstate.cpp.

Revision Contents
Changeset List

Path

Size

src/

compat/

assumptions.h

1 line

node/

chainstate.cpp

1 line

Diff 47808

View Options

src/compat/assumptions.h