Paths

Table of Contentst

Differential D16154

refactor: Move fs.* to util/fs.*
ClosedPublic
Actions

Authored by PiRK on May 14 2024, 11:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC83169f5396a0: refactor: Move fs.* to util/fs.*

Summary

The fs.* files are already part of the libbitcoin_util library. With the
introduction of the fs_helpers.* it makes sense to move fs.* into the
util/ directory as well.

This concludes backport of core#27254
https://github.com/bitcoin/bitcoin/pull/27254/commits/00e9b97f37e0bdf4c647236838c10b68b7ad5be3

Depends on D16153

Test Plan

With Chronik and bitcoin chainstate
ninja all check-all bench-bitcoin bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 14 2024, 11:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2024, 11:01

PiRK requested review of this revision.May 14 2024, 11:01

teamcity edited the summary of this revision. (Show Details)May 14 2024, 11:01

PiRK edited the summary of this revision. (Show Details)May 14 2024, 11:01

PiRK added a parent revision: D16153: Add missing includes in assumptions.h and chainstate.cpp.

Harbormaster completed remote builds in B28997: Diff 47766.May 14 2024, 12:00

Fabien accepted this revision.May 15 2024, 11:39

This revision is now accepted and ready to land.May 15 2024, 11:39

Closed by commit rABC83169f5396a0: refactor: Move fs.* to util/fs.* (authored by PiRK). · Explain WhyMay 16 2024, 08:30

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC83169f5396a0: refactor: Move fs.* to util/fs.*.

Revision Contents
Changeset List

Path

Size

src/

4 lines

2 lines

2 lines

2 lines

bench/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

kernel/

2 lines

2 lines

2 lines

2 lines

2 lines

node/

blockstorage.h

2 lines

blockstorage.cpp

2 lines

chainstate.cpp

2 lines

mempool_persist_args.h

2 lines

mempool_persist_args.cpp

2 lines

utxo_snapshot.h

2 lines

utxo_snapshot.cpp

2 lines

qt/

2 lines

2 lines

2 lines

2 lines

rpc/

2 lines

2 lines

2 lines

2 lines

seeder/

main.cpp

2 lines

test/

fs_tests.cpp

2 lines

fuzz/

banman.cpp

2 lines

settings_tests.cpp

2 lines

streams_tests.cpp

2 lines

util/

2 lines

2 lines

2 lines

2 lines

util/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

	util/

6 lines

2 lines

2 lines

2 lines

wallet/

2 lines

2 lines

2 lines

2 lines

2 lines

rpc/

backup.cpp

2 lines

salvage.h

2 lines

salvage.cpp

2 lines

test/

db_tests.cpp

2 lines

init_test_fixture.cpp

2 lines

2 lines

2 lines

2 lines

2 lines

Diff 47809

View Options

src/CMakeLists.txt

View Options

src/addrdb.h

View Options

src/addrdb.cpp

View Options

src/banman.h

View Options

src/bench/bench.h

View Options

src/bench/bench.cpp

View Options

src/bench/bench_bitcoin.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/dbwrapper.h

View Options

src/flatfile.h

View Options

src/fs.h

View Options

src/fs.cpp

View Options

src/i2p.h

View Options

src/i2p.cpp

View Options

src/init.cpp

View Options

src/kernel/mempool_persist.h

View Options

src/kernel/mempool_persist.cpp

View Options

src/logging.h

View Options

src/logging.cpp

View Options

src/net.cpp

View Options

src/node/blockstorage.h

View Options

src/node/blockstorage.cpp

View Options

src/node/chainstate.cpp

View Options

src/node/mempool_persist_args.h

View Options

src/node/mempool_persist_args.cpp

View Options

src/node/utxo_snapshot.h

View Options

src/node/utxo_snapshot.cpp

View Options

src/qt/guiutil.h

View Options

src/qt/guiutil.cpp

View Options

src/qt/intro.cpp

View Options

src/qt/walletframe.cpp

View Options

src/rpc/blockchain.h

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/mempool.cpp

View Options

src/rpc/request.cpp

View Options

src/seeder/main.cpp

View Options

src/test/fs_tests.cpp

View Options

src/test/fuzz/banman.cpp

View Options

src/test/settings_tests.cpp

View Options

src/test/streams_tests.cpp

View Options

src/test/util/chainstate.h

View Options

src/test/util/setup_common.h

View Options

src/test/util_tests.cpp

View Options

src/txdb.h

View Options

src/util/asmap.h

View Options

src/util/asmap.cpp

View Options

src/util/fs.h

View Options

src/util/fs.cpp

View Options

src/util/fs_helpers.h

View Options

src/util/fs_helpers.cpp

View Options

src/util/getuniquepath.h

View Options

src/util/getuniquepath.cpp

View Options

src/util/readwritefile.h

View Options

src/util/readwritefile.cpp

View Options

src/util/settings.h

View Options

src/util/settings.cpp

View Options

src/util/system.h

View Options

src/util/system.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

src/wallet/bdb.h

View Options

src/wallet/bdb.cpp

View Options

src/wallet/db.h

View Options

src/wallet/db.cpp

View Options

src/wallet/load.cpp

View Options

src/wallet/rpc/backup.cpp

View Options

src/wallet/salvage.h

View Options

src/wallet/salvage.cpp

View Options

src/wallet/test/db_tests.cpp

View Options

src/wallet/test/init_test_fixture.cpp

View Options

src/wallet/wallet.cpp

View Options

src/wallet/walletdb.cpp

View Options

src/wallet/wallettool.cpp

View Options

refactor: Move fs.* to util/fs.*ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47809

src/CMakeLists.txt

src/addrdb.h

src/addrdb.cpp

src/banman.h

src/bench/bench.h

src/bench/bench.cpp

src/bench/bench_bitcoin.cpp

src/bitcoin-tx.cpp

src/dbwrapper.h

src/flatfile.h

src/fs.h

src/fs.cpp

src/i2p.h

src/i2p.cpp

src/init.cpp

src/kernel/mempool_persist.h

src/kernel/mempool_persist.cpp

src/logging.h

src/logging.cpp

src/net.cpp

src/node/blockstorage.h

src/node/blockstorage.cpp

src/node/chainstate.cpp

src/node/mempool_persist_args.h

src/node/mempool_persist_args.cpp

src/node/utxo_snapshot.h

src/node/utxo_snapshot.cpp

src/qt/guiutil.h

src/qt/guiutil.cpp

src/qt/intro.cpp

src/qt/walletframe.cpp

src/rpc/blockchain.h

src/rpc/blockchain.cpp

src/rpc/mempool.cpp

src/rpc/request.cpp

src/seeder/main.cpp

src/test/fs_tests.cpp

src/test/fuzz/banman.cpp

src/test/settings_tests.cpp

src/test/streams_tests.cpp

src/test/util/chainstate.h

src/test/util/setup_common.h

src/test/util_tests.cpp

src/txdb.h

src/util/asmap.h

src/util/asmap.cpp

src/util/fs.h

src/util/fs.cpp

src/util/fs_helpers.h

src/util/fs_helpers.cpp

src/util/getuniquepath.h

src/util/getuniquepath.cpp

src/util/readwritefile.h

src/util/readwritefile.cpp

src/util/settings.h

src/util/settings.cpp

src/util/system.h

src/util/system.cpp

src/validation.h

src/validation.cpp

src/wallet/bdb.h

src/wallet/bdb.cpp

src/wallet/db.h

src/wallet/db.cpp

src/wallet/load.cpp

src/wallet/rpc/backup.cpp

src/wallet/salvage.h

src/wallet/salvage.cpp

src/wallet/test/db_tests.cpp

src/wallet/test/init_test_fixture.cpp

src/wallet/wallet.cpp

src/wallet/walletdb.cpp

src/wallet/wallettool.cpp

src/wallet/walletutil.h

refactor: Move fs.* to util/fs.*
ClosedPublic
Actions

Revision Contents
Changeset List