Make transaction ordering tests easier to debug
ClosedPublic
Actions

Authored by schancel on Aug 2 2018, 20:55.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING4fcdb4c2f859: Make transaction ordering tests easier to debug
rABC4fcdb4c2f859: Make transaction ordering tests easier to debug

Summary

As per title

Test Plan

make VERBOSE=1 check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

mempool-tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3001
Build 4096: Bitcoin ABC Buildbot (legacy)
Build 4095: arc lint + arc unit

Event Timeline

schancel created this revision.Aug 2 2018, 20:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 2 2018, 20:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3001: Diff 4478.Aug 2 2018, 21:40

schancel added a child revision: D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.Aug 3 2018, 01:56

This change shouldn't be necessary. Debugging steps (using gdb) to replicate similar behavior:

break @ CheckSort() calls
break @ BOOST_CHECK_EQUAL() then disable the breakpoint
run
once the breakpoint @ CheckSort() is hit, enable the breakpoint @ BOOST_CHECK_EQUAL()
continue to BOOST_CHECK_EQUAL()

This process can be repeated to skip over unnecessary CheckSort() calls. Additionally, the breakpoint @ BOOST_CHECK_EQUAL() can be made conditional to only hit specific values of count to further reduce the number of breakpoints hit.

This revision now requires changes to proceed.Aug 6 2018, 15:31

Those steps don't actually work for being able to debug these tests. Having some kind of annotation makes debugging much simpler since this test is fragile.

Chatted more offline. This change is an improvement over what we have currently.

This revision is now accepted and ready to land.Aug 6 2018, 17:28

Closed by commit rABC4fcdb4c2f859: Make transaction ordering tests easier to debug (authored by schancel). · Explain WhyAug 6 2018, 17:45

This revision was automatically updated to reflect the committed changes.

nakihito mentioned this in D3711: Merge #12118: Sort mempool by min(feerate, ancestor_feerate).Jul 31 2019, 18:45