Paths

Table of Contentst

Differential D16175

Add pool based memory resource & allocator
ClosedPublic
Actions

Authored by PiRK on May 16 2024, 14:25.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCf93eddc5bfa5: Add pool based memory resource & allocator

Summary

A memory resource similar to std::pmr::unsynchronized_pool_resource, but
optimized for node-based containers.

Co-Authored-By: Pieter Wuille <pieter@wuille.net>

This is a partial backport of core#25325
https://github.com/bitcoin/bitcoin/pull/25325/commits/b8401c3281978beed6198b2f9782b6a8dd35cbd7

with ARM fixes from
https://github.com/bitcoin/bitcoin/pull/28913/commits/ce881bf9fcb7c30bb1fafd6ce38844f4f829452a

Test Plan

ninja all check-all bench-bitcoin

|               ns/op |                op/s |    err% |     total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
|               26.04 |       38,408,682.21 |    1.3% |      0.02 | `PoolAllocator_StdUnorderedMap`
|               10.29 |       97,207,783.17 |    0.3% |      0.01 | `PoolAllocator_StdUnorderedMapWithPoolResource`

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 16 2024, 14:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2024, 14:25

teamcity edited the summary of this revision. (Show Details)May 16 2024, 14:25

Harbormaster completed remote builds in B29029: Diff 47818.May 16 2024, 14:44

PiRK published this revision for review.May 17 2024, 17:28

PiRK added a child revision: D16176: Calculate memory usage correctly for unordered_maps that use PoolAllocator.May 17 2024, 17:41

Fabien accepted this revision.May 20 2024, 08:15

This revision is now accepted and ready to land.May 20 2024, 08:15

Closed by commit rABCf93eddc5bfa5: Add pool based memory resource & allocator (authored by Martin Leitner-Ankerl <martin.ankerl@gmail.com>, committed by PiRK). · Explain WhyMay 20 2024, 15:46

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf93eddc5bfa5: Add pool based memory resource & allocator.

Revision Contents
Changeset List

Path

Size

src/

bench/

1 line

49 lines

support/

allocators/

365 lines

test/

1 line

173 lines

util/

poolresourcetester.h

135 lines

Diff 47836

src/bench/CMakeLists.txt

Loading...

src/bench/pool.cpp

Loading...

src/support/allocators/pool.h

Loading...

src/test/CMakeLists.txt

Loading...

src/test/pool_tests.cpp

Loading...

src/test/util/poolresourcetester.h

Loading...