Page MenuHomePhabricator
Differential D16176

Calculate memory usage correctly for unordered_maps that use PoolAllocator
ClosedPublic
Actions

Authored by PiRK on May 16 2024, 14:30.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC574f749bd839: Calculate memory usage correctly for unordered_maps that use PoolAllocator
Summary

Extracts the resource from a PoolAllocator and uses it for
calculation of the node's memory usage.

This is a partial backport of core#25325
https://github.com/bitcoin/bitcoin/pull/25325/commits/e19943f049ed8aa4f32a1d8440a9fbf160367f0f

with an ARM fix and additional test to make sure the pool is actually used by the nodes from core#28913

Depends on D16175

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 16 2024, 14:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2024, 14:30
teamcity edited the summary of this revision. (Show Details)May 16 2024, 14:30
PiRK added a child revision: D16177: Call ReallocateCache() on each Flush().May 16 2024, 14:39
PiRK added a comment.May 16 2024, 14:41

@bot build-linux32 build-linux-arm

teamcity awarded a token.May 16 2024, 14:41
Harbormaster completed remote builds in B29030: Diff 47819.May 16 2024, 14:53
PiRK published this revision for review.May 17 2024, 17:29
PiRK edited the summary of this revision. (Show Details)May 17 2024, 17:41
PiRK added a parent revision: D16175: Add pool based memory resource & allocator.
Fabien accepted this revision.May 20 2024, 08:17
This revision is now accepted and ready to land.May 20 2024, 08:17
Closed by commit rABC574f749bd839: Calculate memory usage correctly for unordered_maps that use PoolAllocator (authored by Martin Leitner-Ankerl <martin.ankerl@gmail.com>, committed by PiRK). · Explain WhyMay 20 2024, 15:46
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC574f749bd839: Calculate memory usage correctly for unordered_maps that use PoolAllocator.

Revision Contents
Changeset List

PathSize
src/
22 lines
test/
42 lines

Diff 47837

View Options

src/memusage.h

Loading...
View Options

src/test/pool_tests.cpp

Loading...