Page MenuHomePhabricator
Differential D16192

gui: Prompt to reset settings when settings.json cannot be read
ClosedPublic
Actions

Authored by PiRK on May 21 2024, 14:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC62f6ad9702ad: gui: Prompt to reset settings when settings.json cannot be read
Summary

Currently the GUI shows confusing error messages when settings.json can't be read or written on startup. This causes the unrecoverable read error described in core#21340 and write error described core#21974.

This PR tries to clarify the error dialog, and adds an option to just clear the settings and reset them to default

Fixes core#21340

Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>

This is a backport of core-gui#379

Test Plan

ninja && src/qt/bitcoin-qt -settings=/dev/null

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 21 2024, 14:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2024, 14:09
PiRK requested review of this revision.May 21 2024, 14:09
teamcity edited the summary of this revision. (Show Details)May 21 2024, 14:09
PiRK added a child revision: D16193: util: make GetDataDir read-only & create datadir only in bitcoind and bitcoin-qt.May 21 2024, 14:15
Fabien accepted this revision.May 21 2024, 14:28
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/bitcoin.cpp
204–207 ↗(On Diff #47849)

That would have been more elegant, but I guess it's better to stick to the original material here

This revision is now accepted and ready to land.May 21 2024, 14:28
Harbormaster completed remote builds in B29050: Diff 47849.May 21 2024, 14:33
Closed by commit rABC62f6ad9702ad: gui: Prompt to reset settings when settings.json cannot be read (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyMay 22 2024, 05:48
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC62f6ad9702ad: gui: Prompt to reset settings when settings.json cannot be read.

Revision Contents
Changeset List

PathSize
src/
qt/
71 lines

Diff 47876

View Options

src/qt/bitcoin.cpp

Loading...