refactor: Stop using gArgs global in system.cpp
ClosedPublic
Actions

Authored by PiRK on May 21 2024, 15:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC946cd1a1f86a: refactor: Stop using gArgs global in system.cpp

Summary

refactor: Use new GetConfigFilePath function

https://github.com/bitcoin/bitcoin/pull/27170/commits/b20b34f5b33230fe253c81008496bd9b13fd6ecf

refactor: Stop using gArgs global in system.cpp

Most of the code in util/system.cpp that was hardcoded to use the global
ArgsManager instance gArgs has been changed to work with explicit ArgsManager
instances (for example in https://github.com/bitcoin/bitcoin/pull/20092). But a
few hardcoded references to gArgs remain. This commit removes the last ones
so these functions aren't reading or writing global state.

https://github.com/bitcoin/bitcoin/pull/27170/commits/9a9d5da11fa6033f82dcf8e2298aee29587f5396

This is a backport of core#27170

Depends on D16193

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 21 2024, 15:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2024, 15:16

PiRK requested review of this revision.May 21 2024, 15:16

teamcity edited the summary of this revision. (Show Details)May 21 2024, 15:16

Fabien retitled this revision from refactor: Stop using gArgs global in system.cpp# This is a combination of 2 commits. to refactor: Stop using gArgs global in system.cpp.May 21 2024, 15:43

Fabien accepted this revision.May 21 2024, 15:46

This revision is now accepted and ready to land.May 21 2024, 15:46

Harbormaster completed remote builds in B29054: Diff 47861.May 21 2024, 16:33

Closed by commit rABC946cd1a1f86a: refactor: Stop using gArgs global in system.cpp (authored by Ryan Ofsky <ryan@ofsky.org>, committed by PiRK). · Explain WhyMay 22 2024, 05:49

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC946cd1a1f86a: refactor: Stop using gArgs global in system.cpp.