Page MenuHomePhabricator
Differential D16232

txorphange: move orphan workset to txorphanage
ClosedPublic
Actions

Authored by Fabien on May 28 2024, 13:47.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCb16449035def: txorphange: move orphan workset to txorphanage
Summary

Partial backport of core#26295:
https://github.com/bitcoin/bitcoin/pull/26295/commits/3614819864a84ac32f6d53c6ace79b5e71bc174a

Depends on D16231.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 28 2024, 13:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2024, 13:47
Fabien requested review of this revision.May 28 2024, 13:47
teamcity edited the summary of this revision. (Show Details)May 28 2024, 13:47
Fabien added a child revision: D16233: txorphanage: make m_peer_work_set private.May 28 2024, 13:52
Harbormaster completed remote builds in B29145: Diff 47988.May 28 2024, 15:16
PiRK accepted this revision.May 28 2024, 15:57
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/txorphanage.cpp
154 ↗(On Diff #47988)

i was a size_t before, but I don't think it matters when it comes to the number of outputs in a transactions.

This revision is now accepted and ready to land.May 28 2024, 15:57
Fabien added inline comments.May 29 2024, 07:46
src/txorphanage.cpp
154 ↗(On Diff #47988)

size_t is more correct, I will fix

Closed by commit rABCb16449035def: txorphange: move orphan workset to txorphanage (authored by Anthony Towns <aj@erisian.com.au>, committed by Fabien). · Explain WhyMay 29 2024, 07:55
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb16449035def: txorphange: move orphan workset to txorphanage.

Revision Contents
Changeset List

PathSize
src/
24 lines
11 lines
10 lines

Diff 48004

View Options

src/net_processing.cpp

Loading...
View Options

src/txorphanage.h

Loading...
View Options

src/txorphanage.cpp

Loading...