Page MenuHomePhabricator

net_processing: Localise orphan_work_set handling to ProcessOrphanTx
ClosedPublic

Authored by Fabien on May 28 2024, 13:44.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.May 28 2024, 13:44
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/net_processing.cpp
6988–6989 ↗(On Diff #47987)

Our version of the comment was more correct: https://www.btb.termiumplus.gc.ca/tpv2guides/guides/wrtps/index-fra.html?lang=fra&lettr=indx_catlog_p&page=9iulB-Ym0P-o.html

but there is also value in sticking with the grammatical errors from the source material

This revision is now accepted and ready to land.May 28 2024, 15:51
src/net_processing.cpp
6988–6989 ↗(On Diff #47987)

I agree but this does not change the sense of the sentence so I'll stick with source material and avoid merge conflicts