Differential D16231

net_processing: Localise orphan_work_set handling to ProcessOrphanTx
ClosedPublic
Actions

Authored by Fabien on May 28 2024, 13:44.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe0ecca31d444: net_processing: Localise orphan_work_set handling to ProcessOrphanTx

Summary

Partial backport of core#26295:
https://github.com/bitcoin/bitcoin/pull/26295/commits/6f8e442ba61378489a6e2e2ab5bcfbccca1a29ec

Depends on D16230.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR26295_5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29144
Build 57824: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57823: arc lint + arc unit

Event Timeline

Fabien created this revision.May 28 2024, 13:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2024, 13:44

Fabien requested review of this revision.May 28 2024, 13:44

teamcity edited the summary of this revision. (Show Details)May 28 2024, 13:44

Fabien added a child revision: D16232: txorphange: move orphan workset to txorphanage.May 28 2024, 13:47

Harbormaster completed remote builds in B29144: Diff 47987.May 28 2024, 15:17

PiRK accepted this revision.May 28 2024, 15:51

PiRK added a subscriber: PiRK.

PiRK added inline comments.

src/net_processing.cpp
6988–6989	Our version of the comment was more correct: https://www.btb.termiumplus.gc.ca/tpv2guides/guides/wrtps/index-fra.html?lang=fra&lettr=indx_catlog_p&page=9iulB-Ym0P-o.html but there is also value in sticking with the grammatical errors from the source material

This revision is now accepted and ready to land.May 28 2024, 15:51

Fabien added inline comments.May 29 2024, 07:49

src/net_processing.cpp
6988–6989	I agree but this does not change the sense of the sentence so I'll stick with source material and avoid merge conflicts

Closed by commit rABCe0ecca31d444: net_processing: Localise orphan_work_set handling to ProcessOrphanTx (authored by Anthony Towns <aj@erisian.com.au>, committed by Fabien). · Explain WhyMay 29 2024, 07:50

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe0ecca31d444: net_processing: Localise orphan_work_set handling to ProcessOrphanTx.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

32 lines

Diff 47987

src/net_processing.cpp

Loading...