validation: deduplicate forward declaration of Consensus::Params
ClosedPublic
Actions

Authored by PiRK on May 31 2024, 15:45.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8e839c67d4b9: validation: deduplicate forward declaration of Consensus::Params

Summary

This was duplicated in D13244, when backporting https://github.com/bitcoin/bitcoin/pull/24595/commits/69675ea4e73dcf5e9dd0f94802bd3463e4262081

We first added it in D4033

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29188
Build 57912: Build Diff	build-diff · lint-circular-dependencies · build-without-wallet · build-clang · build-clang-tidy · build-debug
Build 57911: arc lint + arc unit

Event Timeline

PiRK created this revision.May 31 2024, 15:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2024, 15:45

PiRK requested review of this revision.May 31 2024, 15:45

PiRK edited the summary of this revision. (Show Details)May 31 2024, 15:47

PiRK added inline comments.

src/validation.h
71–73	here

Harbormaster completed remote builds in B29188: Diff 48065.May 31 2024, 16:08

PiRK added a child revision: D16260: [avalanche] pass a reference to the avalanche processor to StakingRewardsPolicy.May 31 2024, 16:10

Fabien accepted this revision.Mon, Jun 3, 13:24

This revision is now accepted and ready to land.Mon, Jun 3, 13:24

Closed by commit rABC8e839c67d4b9: validation: deduplicate forward declaration of Consensus::Params (authored by PiRK). · Explain WhyMon, Jun 3, 13:31

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8e839c67d4b9: validation: deduplicate forward declaration of Consensus::Params.

Revision Contents
Changeset List

Path

Size

src/

validation.h

4 lines

Diff 48065

View Options

validation: deduplicate forward declaration of Consensus::ParamsClosedPublicActions