Page MenuHomePhabricator
Differential D1629

Seperated BlockStatus class from chain.h file and updated .h and .cpp dependencies.
AbandonedPublic
Actions

Authored by nakihito on Aug 6 2018, 23:52.

Details

Reviewers
jasonbcox
schancel
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Removed the CBlockStatus class from chain.h and placed it into its own .h file, blockstatus.h. Updated other .h and .cpp files for dependencies.

Test Plan

Make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
SeperatingBlockStatusClass
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3033
Build 4159: Bitcoin ABC Buildbot (legacy)
Build 4158: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 6 2018, 23:52
Owners added a reviewer: Restricted Owners Package.Aug 6 2018, 23:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 6 2018, 23:52
teamcity added a subscriber: teamcity.Aug 6 2018, 23:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 6 2018, 23:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3033: Diff 4522!Aug 6 2018, 23:53
teamcity added a comment.Aug 6 2018, 23:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 6 2018, 23:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix requested changes to this revision.Aug 8 2018, 19:29
deadalnix added inline comments.
src/blockstatus.h
1

typo

8

Please include standard lib files after other includes, as doing it that way may hide the fact that our header are broken when they are.

src/diskblockpos.h
9

Why ?

src/test/blockstatus_tests.cpp
7

Remove

This revision now requires changes to proceed.Aug 8 2018, 19:29
nakihito abandoned this revision.Aug 14 2018, 21:18

Revision Contents
Changeset List

PathSize
src/
117 lines
109 lines
8 lines
test/
3 lines

Diff 4522

View Options

src/blockstatus.h

Loading...
View Options

src/chain.h

Loading...
View Options

src/diskblockpos.h

Loading...
View Options

src/test/blockstatus_tests.cpp

Loading...