Differential D16404

Consistently pad the txs in feature_csv_activation
ClosedPublic
Actions

Authored by Fabien on Jul 2 2024, 11:23.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC9af32689ea72: Consistently pad the txs in feature_csv_activation

Summary

This will become a problem when we switch to MiniWallet for this test. Note that pad_tx() also rehashes the tx, so we can avoid doing it twice.

Test Plan

./test/functional/test_runner.py feature_csv_activation

Diff Detail

Repository

rABC Bitcoin ABC

Branch

consistently_pad_tx

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29438
Build 58412: Build Diff	build-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 58411: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 2 2024, 11:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2024, 11:23

Fabien requested review of this revision.Jul 2 2024, 11:23

Fabien added a child revision: D16405: test: use MiniWallet for feature_csv_activation.py.Jul 2 2024, 11:30

PiRK accepted this revision.Jul 2 2024, 12:06

This revision is now accepted and ready to land.Jul 2 2024, 12:06

Harbormaster completed remote builds in B29438: Diff 48450.Jul 2 2024, 12:18

Closed by commit rABC9af32689ea72: Consistently pad the txs in feature_csv_activation (authored by Fabien). · Explain WhyJul 2 2024, 12:35

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9af32689ea72: Consistently pad the txs in feature_csv_activation.

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_csv_activation.py

7 lines

Diff 48450

View Options

test/functional/feature_csv_activation.py

Consistently pad the txs in feature_csv_activationClosedPublicActions