Page MenuHomePhabricator
Differential D16437

[Cashtab] Update comment and TODO in sendXec function
ClosedPublic
Actions

Authored by bytesofman on Jul 9 2024, 20:39.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC3fe72d4b1ede: [Cashtab] Update comment and TODO in sendXec function
Summary

Should have been updated when isTokenDustChangeOutput was introduced.

Test Plan

proofread, npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Jul 9 2024, 20:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2024, 20:39
Harbormaster completed remote builds in B29512: Diff 48561.Jul 9 2024, 20:39
bytesofman published this revision for review.Jul 9 2024, 21:04
bytesofman updated this revision to Diff 48562.Jul 9 2024, 21:04

rebase

Harbormaster completed remote builds in B29513: Diff 48562.Jul 9 2024, 21:04
bytesofman mentioned this in D16436: [Cashtab] Only add inputs to a tx if you need them.Jul 9 2024, 21:07

note: tests are passing locally, CI failure does not seem related to this diff. Unable to parse issue from log

emack added a subscriber: emack.Jul 10 2024, 03:04

@bot cashtab-tests

PiRK accepted this revision.Jul 10 2024, 06:24
This revision is now accepted and ready to land.Jul 10 2024, 06:24
teamcity awarded a token.Jul 10 2024, 08:16
This revision was landed with ongoing or failed builds.Jul 10 2024, 16:24
Closed by commit rABC3fe72d4b1ede: [Cashtab] Update comment and TODO in sendXec function (authored by bytesofman). · Explain Why
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC3fe72d4b1ede: [Cashtab] Update comment and TODO in sendXec function.

Revision Contents
Changeset List

PathSize
cashtab/
4 lines
2 lines
src/
transactions/
3 lines

Diff 48569

View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/transactions/index.js

Loading...