Page MenuHomePhabricator

net processing: clamp PeerManager::Options user input
ClosedPublic

Authored by PiRK on Jul 12 2024, 10:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC83352fab4390: net processing: clamp PeerManager::Options user input
Summary

Document PeerManager::Options members.

Clamp -maxorphantx to uint32_t bounds.

Clamp -blockreconstructionextratxn to uint32_t bounds.
Also changes max_extra_txs into a uint32_t to avoid platform-specific behaviour.

-maxaddrtosend is hidden option used only for tests, so we only do minimal boundary checks.

This is a backport of core#28149

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable