Page MenuHomePhabricator

[Cashtab] Update paywall article link
ClosedPublic

Authored by emack on Jul 12 2024, 14:39.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC0f69d70a11ba: [Cashtab] Update paywall article link
Summary

The current paywall article link in tx history is a placeholder pointing to the tx on explorer where the article was created.

Now that direct sharing of articles has been in use for some time, this diff updates it to point directly to the article itself.

Test Plan

open a wallet that has received or sent a paywall payment, click on Paywall Article and ensure it directs to the article on eCashChat.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
updatePaywallLink
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29550
Build 58635: Build Diffecash-lib-tests · cashtab-tests
Build 58634: arc lint + arc unit

Event Timeline

cashtab/src/components/Home/Tx/index.js
592–601 ↗(On Diff #48611)

arc lint kept auto indenting these even though I haven't touched this, wouldn't let me push this otherwise.

emack published this revision for review.Jul 12 2024, 14:44
bytesofman added inline comments.
cashtab/src/components/Home/Tx/index.js
592–601 ↗(On Diff #48611)

what happens if you run arc lint on master after, say, just adding a commented line in this file?

might be related to formatting changes elsewhere in this file but probably due to global eslint or prettier at different version. the formatting is "better" so not a bad change, though would be better to isolate it.

This revision is now accepted and ready to land.Jul 12 2024, 19:42
emack marked an inline comment as done.

Version bump

cashtab/src/components/Home/Tx/index.js
592–601 ↗(On Diff #48611)

arc lint on master after adding a simple commented line in this file triggers the same indentations above.

your eslint is 8.3.0 right?

This revision was automatically updated to reflect the committed changes.