Page MenuHomePhabricator

[Cashtab] Patch dockerfile to build ecash-agora correctly
ClosedPublic

Authored by bytesofman on Jul 20 2024, 23:29.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCbb1d83b52741: [Cashtab] Patch dockerfile to build ecash-agora correctly
Summary

D16496 broke Cashtab deployments as the Dockerfile is missing a COPY statement. Add it here.

Test Plan

docker build -f cashtab.Dockerfile -t cashtab_local .

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack added a subscriber: emack.

Semi-related nit: Update CONTRIBUTING.md to run this docker build -f cashtab.Dockerfile -t cashtab_local . before you can hop into the Cashtab repo and run docker-compose build, otherwise it will fail due to no config files. Alternatively just add this step to Cashtab README's dependency paragraph in the Development section.

This revision is now accepted and ready to land.Jul 21 2024, 01:55

Semi-related nit: Update CONTRIBUTING.md to run this docker build -f cashtab.Dockerfile -t cashtab_local . before you can hop into the Cashtab repo and run docker-compose build, otherwise it will fail due to no config files. Alternatively just add this step to Cashtab README's dependency paragraph in the Development section.

Actually even after running that you still won't have a docker-compose.yml inside the Cashtab repo. So is this section oudated?