[Cashtab] Patch dockerfile to build ecash-agora correctly
ClosedPublic
Actions

Authored by bytesofman on Jul 20 2024, 23:29.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCbb1d83b52741: [Cashtab] Patch dockerfile to build ecash-agora correctly

Summary

D16496 broke Cashtab deployments as the Dockerfile is missing a COPY statement. Add it here.

Test Plan

docker build -f cashtab.Dockerfile -t cashtab_local .

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cashtab-agora-deployment-patch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29645
Build 58825: Build Diff
Build 58824: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 20 2024, 23:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2024, 23:29

Harbormaster completed remote builds in B29645: Diff 48756.Jul 20 2024, 23:29

bytesofman published this revision for review.Jul 20 2024, 23:30

Semi-related nit: Update CONTRIBUTING.md to run this docker build -f cashtab.Dockerfile -t cashtab_local . before you can hop into the Cashtab repo and run docker-compose build, otherwise it will fail due to no config files. Alternatively just add this step to Cashtab README's dependency paragraph in the Development section.

This revision is now accepted and ready to land.Jul 21 2024, 01:55

In D16510#373511, @emack wrote:

Semi-related nit: Update CONTRIBUTING.md to run this docker build -f cashtab.Dockerfile -t cashtab_local . before you can hop into the Cashtab repo and run docker-compose build, otherwise it will fail due to no config files. Alternatively just add this step to Cashtab README's dependency paragraph in the Development section.

Actually even after running that you still won't have a docker-compose.yml inside the Cashtab repo. So is this section oudated?

Closed by commit rABCbb1d83b52741: [Cashtab] Patch dockerfile to build ecash-agora correctly (authored by bytesofman). · Explain WhyJul 21 2024, 02:54

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCbb1d83b52741: [Cashtab] Patch dockerfile to build ecash-agora correctly.

bytesofman mentioned this in D16511: [Cashtab] Update README to reflect current deployment requirements.Jul 21 2024, 02:59

bytesofman mentioned this in rABC16fbc917f0d4: [Cashtab] Update README to reflect current deployment requirements.Jul 22 2024, 18:49