Page MenuHomePhabricator

[Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat
ClosedPublic

Authored by emack on Jul 21 2024, 15:49.

Details

Summary

Update tx history parsing to recognize the lokaid IDs for eCashChat actions in submitting an article and a reply to an article.

Article reply before

image.png (642×898 px, 383 KB)

Article reply after

image.png (317×824 px, 115 KB)

Article post before

image.png (403×895 px, 160 KB)

Article post after

image.png (216×829 px, 54 KB)

Test Plan

npm test
click on the article link on an article reply tx in tx history and ensure it takes the user to the direct article on eCashChat

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecashchatActionUpdate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29647
Build 58829: Build Diffecash-lib-tests · cashtab-tests
Build 58828: arc lint + arc unit

Event Timeline

emack published this revision for review.Jul 21 2024, 16:12
Fabien requested changes to this revision.Jul 22 2024, 07:39
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/src/components/Home/Tx/index.js
464 ↗(On Diff #48761)

You didn't check the stackArray size, this could very well be an out of bounds access

This revision now requires changes to proceed.Jul 22 2024, 07:39
emack marked an inline comment as done.

Added stackArray size check and updated int tests

This revision is now accepted and ready to land.Aug 1 2024, 09:42