Differential D16530

[Chronik] Remove unneeded `.as_ref()` call
ClosedPublic
Actions

Authored by tobias_ruck on Jul 24 2024, 00:35.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC76ec1d497a76: [Chronik] Remove unneeded `.as_ref()` call

Summary

This call is unneeded and magically breaks the type inference when plugins are enabled.

Might be a compiler bug; but since this is a good change regardless there's little point in investigating deeper.

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-remove-as_ref-call

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29700
Build 58935: Build Diff	chronik-client-integration-tests · ecash-lib-integration-tests · ecash-agora-integration-tests · build-chronik-plugins · build-chronik
Build 58934: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Jul 24 2024, 00:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 24 2024, 00:35

tobias_ruck requested review of this revision.Jul 24 2024, 00:35

tobias_ruck added a child revision: D16525: [Chronik] Add `plugin` field to `TxInput` in `tx.py`.Jul 24 2024, 00:36

Harbormaster completed remote builds in B29689: Diff 48809.Jul 24 2024, 00:51

also fix one such usage in test_batch_nft1.rs

tobias_ruck retitled this revision from [Chronik] MempoolGroupUtxos: Remove unneeded `.as_ref()` call to [Chronik] Remove unneeded `.as_ref()` call.Jul 24 2024, 10:22

Harbormaster completed remote builds in B29700: Diff 48821.Jul 24 2024, 10:45

tobias_ruck edited the summary of this revision. (Show Details)Jul 24 2024, 11:21

Fabien accepted this revision.Jul 24 2024, 12:11

This revision is now accepted and ready to land.Jul 24 2024, 12:11

Closed by commit rABC76ec1d497a76: [Chronik] Remove unneeded `.as_ref()` call (authored by tobias_ruck). · Explain WhyJul 24 2024, 19:29

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC76ec1d497a76: [Chronik] Remove unneeded `.as_ref()` call.