[explorer] Render token icon next to token inputs, outputs, and in token summary table
ClosedPublic
Actions

Authored by bytesofman on Aug 9 2024, 00:47.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC23ad4a4dbe13: [explorer] Render token icon next to token inputs, outputs, and in token…

Summary

Render the token icon next to token inputs and outputs, including the mint baton. Also render in the token summary table and the eTokens table on the address page.

Note: a blockie is generated server-side for tokens that do not have an icon.

Test Plan

cargo run, check out the genesis tx for some tokens with and without icons.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

render-token-icon-on-output

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29928
Build 59391: Build Diff
Build 59390: arc lint + arc unit

Event Timeline

bytesofman created this revision.Aug 9 2024, 00:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 9 2024, 00:47

Harbormaster completed remote builds in B29913: Diff 49112.Aug 9 2024, 00:47

web/explorer/explorer-server/templates/components/input.html
44 ↗	(On Diff #49112)	the base URL should be stored as a constant somewhere, I'm not (yet) sure how to best do this in rust

@bot preview-explorer

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://51.83.66.92:41539 for the next 60 minutes.

Any chance we can have the icon also on transactions page (or is there any reason why you didn't do it) ?

web/explorer/explorer-server/templates/components/input.html
44 ↗	(On Diff #49112)	you need to add the url in the model (templating.rs) and fill it with the constant when the model is constructed (in server.rs)

This revision now requires changes to proceed.Aug 10 2024, 08:43

use constant for token server url, add to Address page, ensure size constraint

Harbormaster completed remote builds in B29928: Diff 49135.Aug 10 2024, 18:14

In D16611#376253, @Fabien wrote:

Any chance we can have the icon also on transactions page (or is there any reason why you didn't do it) ?

added to the Address page

I looked at also adding it to the transactions table -- e.g. on the block page -- this though requires a different implementation. I don't think it would be that complicated, but might need to repeat the url constant as this table is built by a JS file and not the template. I don't think we really need it there though.

bytesofman edited the summary of this revision. (Show Details)Aug 10 2024, 18:18

bytesofman edited the test plan for this revision. (Show Details)

bytesofman edited the summary of this revision. (Show Details)

bytesofman removed a parent revision: D16610: [explorer] Render cashaddr for all inputs and outputs on transaction page.

@bot preview-explorer

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://51.178.130.230:41917 for the next 60 minutes.

In D16611#376298, @bytesofman wrote:

In D16611#376253, @Fabien wrote:

Any chance we can have the icon also on transactions page (or is there any reason why you didn't do it) ?

added to the Address page

I looked at also adding it to the transactions table -- e.g. on the block page -- this though requires a different implementation. I don't think it would be that complicated, but might need to repeat the url constant as this table is built by a JS file and not the template. I don't think we really need it there though.