Differential D16700

[cmake] Add an option to build the secp256k1 library as shared
ClosedPublic
Actions

Authored by Fabien on Sep 2 2024, 08:35.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCa8ce9a440b5a: [cmake] Add an option to build the secp256k1 library as shared

Summary

This does not affect the other libraries and make it easier to build the shared libsecp256k1 from the monorepo.

Test Plan

cmake -GNinja .. -DSECP256K1_BUILD_SHARED=ON
ninja secp256k1

Check the shared lib is produced.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secp256k1_shared

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30147
Build 59827: Build Diff	lint-circular-dependencies · build-without-wallet · build-secp256k1-bench · build-secp256k1-java · build-secp256k1 · build-clang · build-diff · build-clang-tidy · build-debug
Build 59826: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 2 2024, 08:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2024, 08:35

Fabien requested review of this revision.Sep 2 2024, 08:35

PiRK accepted this revision.Sep 2 2024, 08:41

This revision is now accepted and ready to land.Sep 2 2024, 08:41

Harbormaster completed remote builds in B30147: Diff 49433.Sep 2 2024, 08:54

Closed by commit rABCa8ce9a440b5a: [cmake] Add an option to build the secp256k1 library as shared (authored by Fabien). · Explain WhySep 2 2024, 08:58

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa8ce9a440b5a: [cmake] Add an option to build the secp256k1 library as shared.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

9 lines

Diff 49433

src/secp256k1/CMakeLists.txt

Loading...