Page MenuHomePhabricator

[Chronik] Add plugin group tx history
ClosedPublic

Authored by tobias_ruck on Sep 3 2024, 15:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe34f9117bc05: [Chronik] Add plugin group tx history
Summary

Add tx history of groups assigned by plugins using GroupHistory{Writer,Reader} and MempoolGroupHistory, and add the corresponding HTTP endpoints /plugin/:plugin_name/:group_hex/{confirmed-txs,unconfirmed-txs,history}.

Depends on D16723.

Test Plan

./test/functional/test_runner.py chronik_plugins

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Failed tests logs:

====== Bitcoin ABC functional tests: chronik_plugins.py ======

------- Stdout: -------
2024-09-03T16:04:56.716000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20240903_160039/chronik_plugins_143
2024-09-03T16:04:57.993000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_plugins.py", line 157, in run_test
    assert_equal(plugin.unconfirmed_txs(b"a").ok().txs, [proto_tx1])
  File "/work/test/functional/test_framework/util.py", line 59, in assert_equal
    if thing1 != thing2 or any(thing1 != arg for arg in args):
TypeError: Can only compare repeated composite fields against other repeated composite fields.
2024-09-03T16:04:58.044000Z TestFramework (INFO): Stopping nodes
2024-09-03T16:04:58.146000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20240903_160039/chronik_plugins_143
2024-09-03T16:04:58.146000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20240903_160039/chronik_plugins_143/test_framework.log
2024-09-03T16:04:58.146000Z TestFramework (ERROR): 
2024-09-03T16:04:58.146000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20240903_160039/chronik_plugins_143' to consolidate all logs
2024-09-03T16:04:58.146000Z TestFramework (ERROR): 
2024-09-03T16:04:58.146000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-09-03T16:04:58.146000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-09-03T16:04:58.146000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: chronik_plugins.py

tobias_ruck edited the summary of this revision. (Show Details)

separate out fix

tobias_ruck retitled this revision from [Chronik] Add plugin group tx history, fix plugin mempool to [Chronik] Add plugin group tx history.
This revision is now accepted and ready to land.Sep 5 2024, 18:16
This revision was automatically updated to reflect the committed changes.