Page MenuHomePhabricator

Move CFeeRate into its own source files
ClosedPublic

Authored by schancel on Aug 24 2018, 21:21.

Details

Summary
As per title
Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Aug 24 2018, 21:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2018, 21:21
schancel retitled this revision from Move CFeeRate to it's own files to Move CFeeRate into its own source files.Aug 24 2018, 21:24
jasonbcox requested changes to this revision.Aug 24 2018, 21:27
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/amount.cpp
15 ↗(On Diff #4646)

Can this be rolled up into amount.h? Doesn't look like there's much use in having a separate file for just this 1-liner function.

This revision now requires changes to proceed.Aug 24 2018, 21:27
schancel added inline comments.Aug 24 2018, 21:30
src/amount.cpp
15 ↗(On Diff #4646)

I don't see a good reason to do that. Then you need tinyformat in amount.h, etc.

jasonbcox accepted this revision.Aug 24 2018, 21:32
jasonbcox added inline comments.
src/amount.cpp
15 ↗(On Diff #4646)

good point

This revision is now accepted and ready to land.Aug 24 2018, 21:32
This revision was automatically updated to reflect the committed changes.