Page MenuHomePhabricator

Move CFeeRate into its own source files
ClosedPublic

Authored by schancel on Aug 24 2018, 21:21.

Details

Summary
As per title
Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3121
Build 4329: Bitcoin ABC Buildbot (legacy)
Build 4328: arc lint + arc unit

Event Timeline

schancel retitled this revision from Move CFeeRate to it's own files to Move CFeeRate into its own source files.Aug 24 2018, 21:24
jasonbcox requested changes to this revision.Aug 24 2018, 21:27
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/amount.cpp
15

Can this be rolled up into amount.h? Doesn't look like there's much use in having a separate file for just this 1-liner function.

This revision now requires changes to proceed.Aug 24 2018, 21:27
src/amount.cpp
15

I don't see a good reason to do that. Then you need tinyformat in amount.h, etc.

jasonbcox added inline comments.
src/amount.cpp
15

good point

This revision is now accepted and ready to land.Aug 24 2018, 21:32
This revision was automatically updated to reflect the committed changes.