Page MenuHomePhabricator
Differential D1673

Move CFeeRate into its own source files
ClosedPublic
Actions

Authored by schancel on Aug 24 2018, 21:21.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING87d967d48f27: Move CFeeRate into its own source files
rABC87d967d48f27: Move CFeeRate into its own source files
Summary
As per title
Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3121
Build 4329: Bitcoin ABC Buildbot (legacy)
Build 4328: arc lint + arc unit

Event Timeline

schancel created this revision.Aug 24 2018, 21:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2018, 21:21
teamcity added a subscriber: teamcity.Aug 24 2018, 21:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel retitled this revision from Move CFeeRate to it's own files to Move CFeeRate into its own source files.Aug 24 2018, 21:24
jasonbcox requested changes to this revision.Aug 24 2018, 21:27
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/amount.cpp
15

Can this be rolled up into amount.h? Doesn't look like there's much use in having a separate file for just this 1-liner function.

This revision now requires changes to proceed.Aug 24 2018, 21:27
schancel added inline comments.Aug 24 2018, 21:30
src/amount.cpp
15

I don't see a good reason to do that. Then you need tinyformat in amount.h, etc.

jasonbcox accepted this revision.Aug 24 2018, 21:32
jasonbcox added inline comments.
src/amount.cpp
15

good point

This revision is now accepted and ready to land.Aug 24 2018, 21:32
teamcity added a comment.Aug 24 2018, 21:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3121: Diff 4646.Aug 24 2018, 21:59
Closed by commit rABC87d967d48f27: Move CFeeRate into its own source files (authored by schancel). · Explain WhyAug 24 2018, 22:04
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
63 lines
54 lines
1 line
80 lines
feerate.cpp
amount.cpp
8 lines
policy/
1 line
primitives/
1 line

Diff 4646

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/amount.h

Loading...
View Options

src/amount.cpp

Loading...
View Options

src/config.h

Loading...
View Options

src/feerate.h

Loading...
View Options

src/feerate.cpp

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/primitives/transaction.h

Loading...