[ecash-lib] Use `new Error` when throwing errors in `WriterBytes`
ClosedPublic
Actions

Authored by tobias_ruck on Sep 10 2024, 10:30.

Details

Reviewers

bytesofman
Fabien

Group Reviewers

Restricted Project

Commits

rABC2ad9f8628a5f: [ecash-lib] Use `new Error` when throwing errors in `WriterBytes`

Summary

Currently we throw strings directly, and node refuses to give us a stack trace in this case and tells us to use Error instead, so we do that.

Test Plan

npm run test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Sep 10 2024, 10:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2024, 10:30

tobias_ruck requested review of this revision.Sep 10 2024, 10:30

Harbormaster completed remote builds in B30229: Diff 49556.Sep 10 2024, 10:38

Fabien accepted this revision.Sep 10 2024, 14:23

This revision is now accepted and ready to land.Sep 10 2024, 14:23

Closed by commit rABC2ad9f8628a5f: [ecash-lib] Use `new Error` when throwing errors in `WriterBytes` (authored by tobias_ruck). · Explain WhySep 10 2024, 22:26

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC2ad9f8628a5f: [ecash-lib] Use `new Error` when throwing errors in `WriterBytes`.

Revision Contents
Changeset List

Path

Size

modules/

ecash-lib/

src/

io/

writerbytes.ts

14 lines

Diff 49568

View Options

modules/ecash-lib/src/io/writerbytes.ts

[ecash-lib] Use `new Error` when throwing errors in `WriterBytes`ClosedPublicActions