Details

Reviewers

roqqit
PiRK

Group Reviewers

Restricted Project

Commits

rABCcec261f248b8: Store the last 20 headers reception time to a file

Summary

And load it at startup. This is bootstrapping the RTT algorithm so the difficulty might only be over-estimated after a restart and miners won't mine rejected blocks.

This is opt-in because most nodes simply don't need the feature, it's an optimization that only impacts the miners.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

store_header_time

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30369
Build 60258: Build Diff	lint-circular-dependencies · build-without-wallet · build-debug · build-clang-tidy · build-clang · build-diff
Build 60257: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 19 2024, 23:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 19 2024, 23:41

Fabien requested review of this revision.Sep 19 2024, 23:41

Harbormaster completed remote builds in B30369: Diff 49751.Sep 20 2024, 00:02

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mwallet_startup.py                          | ✓ Passed  | 6 s
[0m[0;32mwallet_timelock.py                         | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py                        | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_clone.py --mineblock            | ✓ Passed  | 5 s
[0m[0;32mwallet_txn_doublespend.py                  | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_doublespend.py --mineblock      | ✓ Passed  | 5 s
[0m[0;32mwallet_watchonly.py                        | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py --usecli               | ✓ Passed  | 4 s
[0m[1;30mchronik_avalanche.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_block.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_block_header.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_block_info.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_block_txs.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_blockchain_info.py                 | ○ Skipped | 0 s
[0m[1;30mchronik_blocks.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_chronik_info.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_cors.py                            | ○ Skipped | 0 s
[0m[1;30mchronik_disable_token_index.py             | ○ Skipped | 0 s
[0m[1;30mchronik_disallow_prune.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_lokad_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_mempool_conflicts.py               | ○ Skipped | 0 s
[0m[1;30mchronik_mempool_disconnectpool.py          | ○ Skipped | 0 s
[0m[1;30mchronik_pause.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_plugin_groups.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_plugins.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_plugins_setup.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_raw_tx.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_resync.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_script_confirmed_txs.py            | ○ Skipped | 0 s
[0m[1;30mchronik_script_history.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_script_unconfirmed_txs.py          | ○ Skipped | 0 s
[0m[1;30mchronik_script_utxos.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_serve.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_spent_by.py                        | ○ Skipped | 0 s
[0m[1;30mchronik_token_alp.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_token_broadcast_txs.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_burn.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_token_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_token_parse_failure.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_script_group.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_fungible.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_mint_vault.py            | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_nft1.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_tx.py                              | ○ Skipped | 0 s
[0m[1;30mchronik_tx_removal_order.py                | ○ Skipped | 0 s
[0m[1;30mchronik_ws.py                              | ○ Skipped | 0 s
[0m[1;30mchronik_ws_ordering.py                     | ○ Skipped | 0 s
[0m[1;30mchronik_ws_ping.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_ws_script.py                       | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_discover.py              | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_externalip.py            | ○ Skipped | 0 s
[0m[1;30minterface_usdt_net.py                      | ○ Skipped | 0 s
[0m[1;30minterface_usdt_utxocache.py                | ○ Skipped | 0 s
[0m[1;30minterface_usdt_validation.py               | ○ Skipped | 0 s
[0m[1m
ALL                                        | ✓ Passed  | 2298 s (accumulated) 
[0mRuntime: 465 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

roqqit accepted this revision.Sep 20 2024, 00:37

roqqit added a subscriber: roqqit.

roqqit added inline comments.

src/node/chainstatemanager_args.cpp
21	linter doesn't catch this?
src/test/validation_chainstatemanager_tests.cpp
760

This revision is now accepted and ready to land.Sep 20 2024, 00:37

The patch looks ok but there is a test failure

This revision now requires changes to proceed.Sep 20 2024, 00:38

Improve logging + feedback

I can't reproduce the test failure locally, the load function is failing in the test.
I'll need to improve the reporting a bit to investigate, this diff will be rebased to do so.

Fabien added inline comments.Sep 20 2024, 08:21