Page MenuHomePhabricator
Differential D16791

Store the last 20 headers reception time to a file
ClosedPublic
Actions

Authored by Fabien on Sep 19 2024, 23:41.

Details

Reviewers
roqqit
PiRK
Group Reviewers
Restricted Project
Commits
rABCcec261f248b8: Store the last 20 headers reception time to a file
Summary

And load it at startup. This is bootstrapping the RTT algorithm so the difficulty might only be over-estimated after a restart and miners won't mine rejected blocks.

This is opt-in because most nodes simply don't need the feature, it's an optimization that only impacts the miners.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Sep 19 2024, 23:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 19 2024, 23:41
Fabien requested review of this revision.Sep 19 2024, 23:41
Harbormaster completed remote builds in B30369: Diff 49751.Sep 20 2024, 00:02
teamcity added a comment.Sep 20 2024, 00:02
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

wallet_startup.py                          | ✓ Passed  | 6 s
wallet_timelock.py                         | ✓ Passed  | 2 s
wallet_txn_clone.py                        | ✓ Passed  | 4 s
wallet_txn_clone.py --mineblock            | ✓ Passed  | 5 s
wallet_txn_doublespend.py                  | ✓ Passed  | 4 s
wallet_txn_doublespend.py --mineblock      | ✓ Passed  | 5 s
wallet_watchonly.py                        | ✓ Passed  | 3 s
wallet_watchonly.py --usecli               | ✓ Passed  | 4 s
chronik_avalanche.py                       | ○ Skipped | 0 s
chronik_block.py                           | ○ Skipped | 0 s
chronik_block_header.py                    | ○ Skipped | 0 s
chronik_block_info.py                      | ○ Skipped | 0 s
chronik_block_txs.py                       | ○ Skipped | 0 s
chronik_blockchain_info.py                 | ○ Skipped | 0 s
chronik_blocks.py                          | ○ Skipped | 0 s
chronik_chronik_info.py                    | ○ Skipped | 0 s
chronik_cors.py                            | ○ Skipped | 0 s
chronik_disable_token_index.py             | ○ Skipped | 0 s
chronik_disallow_prune.py                  | ○ Skipped | 0 s
chronik_lokad_id_group.py                  | ○ Skipped | 0 s
chronik_mempool_conflicts.py               | ○ Skipped | 0 s
chronik_mempool_disconnectpool.py          | ○ Skipped | 0 s
chronik_pause.py                           | ○ Skipped | 0 s
chronik_plugin_groups.py                   | ○ Skipped | 0 s
chronik_plugins.py                         | ○ Skipped | 0 s
chronik_plugins_setup.py                   | ○ Skipped | 0 s
chronik_raw_tx.py                          | ○ Skipped | 0 s
chronik_resync.py                          | ○ Skipped | 0 s
chronik_script_confirmed_txs.py            | ○ Skipped | 0 s
chronik_script_history.py                  | ○ Skipped | 0 s
chronik_script_unconfirmed_txs.py          | ○ Skipped | 0 s
chronik_script_utxos.py                    | ○ Skipped | 0 s
chronik_serve.py                           | ○ Skipped | 0 s
chronik_spent_by.py                        | ○ Skipped | 0 s
chronik_token_alp.py                       | ○ Skipped | 0 s
chronik_token_broadcast_txs.py             | ○ Skipped | 0 s
chronik_token_burn.py                      | ○ Skipped | 0 s
chronik_token_id_group.py                  | ○ Skipped | 0 s
chronik_token_parse_failure.py             | ○ Skipped | 0 s
chronik_token_script_group.py              | ○ Skipped | 0 s
chronik_token_slp_fungible.py              | ○ Skipped | 0 s
chronik_token_slp_mint_vault.py            | ○ Skipped | 0 s
chronik_token_slp_nft1.py                  | ○ Skipped | 0 s
chronik_tx.py                              | ○ Skipped | 0 s
chronik_tx_removal_order.py                | ○ Skipped | 0 s
chronik_ws.py                              | ○ Skipped | 0 s
chronik_ws_ordering.py                     | ○ Skipped | 0 s
chronik_ws_ping.py                         | ○ Skipped | 0 s
chronik_ws_script.py                       | ○ Skipped | 0 s
feature_bind_port_discover.py              | ○ Skipped | 0 s
feature_bind_port_externalip.py            | ○ Skipped | 0 s
interface_usdt_net.py                      | ○ Skipped | 0 s
interface_usdt_utxocache.py                | ○ Skipped | 0 s
interface_usdt_validation.py               | ○ Skipped | 0 s

ALL                                        | ✓ Passed  | 2298 s (accumulated) 
Runtime: 465 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
roqqit accepted this revision.Sep 20 2024, 00:37
roqqit added a subscriber: roqqit.
roqqit added inline comments.
src/node/chainstatemanager_args.cpp
21 ↗(On Diff #49751)

linter doesn't catch this?

src/test/validation_chainstatemanager_tests.cpp
760 ↗(On Diff #49751)
This revision is now accepted and ready to land.Sep 20 2024, 00:37
roqqit requested changes to this revision.Sep 20 2024, 00:38

The patch looks ok but there is a test failure

This revision now requires changes to proceed.Sep 20 2024, 00:38
Fabien updated this revision to Diff 49755.Sep 20 2024, 08:09

Improve logging + feedback

I can't reproduce the test failure locally, the load function is failing in the test.
I'll need to improve the reporting a bit to investigate, this diff will be rebased to do so.

Fabien added inline comments.Sep 20 2024, 08:21
src/node/chainstatemanager_args.cpp
21 ↗(On Diff #49751)

Apparently it doesn't

Harbormaster completed remote builds in B30373: Diff 49755.Sep 20 2024, 08:26
Fabien updated this revision to Diff 49757.Sep 20 2024, 09:44

Rebase on top of D16794, hopefully to test will fail

Harbormaster completed remote builds in B30375: Diff 49757.Sep 20 2024, 10:03
Fabien added a comment.Sep 20 2024, 11:34

@bot build-diff

teamcity awarded a token.Sep 20 2024, 11:34
Fabien added a comment.Sep 20 2024, 14:46

@bot build-diff

teamcity updated a token.Sep 20 2024, 14:46
Fabien planned changes to this revision.Sep 20 2024, 20:22

The option should not be hidden

Fabien updated this revision to Diff 49766.Sep 21 2024, 07:52

Document -persistrecentheaderstime

Harbormaster completed remote builds in B30380: Diff 49766.Sep 21 2024, 08:10
PiRK accepted this revision.Sep 23 2024, 07:30
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/test/validation_chainstatemanager_tests.cpp
800 ↗(On Diff #49766)
Fabien updated this revision to Diff 49770.Sep 23 2024, 07:34

Rebase and fix typo

Harbormaster completed remote builds in B30384: Diff 49770.Sep 23 2024, 07:52
roqqit accepted this revision.Sep 23 2024, 16:15
This revision is now accepted and ready to land.Sep 23 2024, 16:15
Closed by commit rABCcec261f248b8: Store the last 20 headers reception time to a file (authored by Fabien). · Explain WhySep 24 2024, 14:30
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCcec261f248b8: Store the last 20 headers reception time to a file.

Revision Contents
Changeset List

Diff 49757

View Options

src/init.cpp

Loading...
View Options

src/kernel/chainstatemanager_opts.h

Loading...
View Options

src/node/chainstatemanager_args.cpp

Loading...
View Options

src/test/validation_chainstatemanager_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/abc_feature_persist_headers_time.py

Loading...
View Options

test/lint/check-doc.py

Loading...