Differential D16830

[chronik-plugin] Rename token to etoken
ClosedPublic
Actions

Authored by Fabien on Oct 1 2024, 12:08.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCc01feda057b7: [chronik-plugin] Rename token to etoken

Summary

The token.py python module conflicts with the built-in python module of the same name. This is confusing and also causes flake8 to report an error, preventing the linters from doing their magic.

Test Plan

With Chronik and the plugins built:

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik_plugin_etoken

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30444
Build 60407: Build Diff	chronik-client-integration-tests · ecash-agora-integration-tests · ecash-agora-tests · build-chronik-plugins · ecash-lib-integration-tests · build-chronik
Build 60406: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 1 2024, 12:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2024, 12:08

Fabien requested review of this revision.Oct 1 2024, 12:08

Fabien added a child revision: D16831: Lint everything.Oct 1 2024, 12:29

Harbormaster completed remote builds in B30444: Diff 49864.Oct 1 2024, 12:33

tobias_ruck accepted this revision.Oct 1 2024, 14:47

This revision is now accepted and ready to land.Oct 1 2024, 14:47

Closed by commit rABCc01feda057b7: [chronik-plugin] Rename token to etoken (authored by Fabien). · Explain WhyOct 1 2024, 14:49

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc01feda057b7: [chronik-plugin] Rename token to etoken.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-plugin-impl/

src/

	etoken.py
	token.py

93 lines

	etoken.rs
	token.rs

6 lines

2 lines

6 lines

2 lines

2 lines

tests/

test_tx_to_py.py

2 lines

modules/

ecash-agora/

2 lines

Diff 49864

chronik/chronik-plugin-impl/src/etoken.py

Loading...

chronik/chronik-plugin-impl/src/etoken.rs

Loading...

chronik/chronik-plugin-impl/src/lib.rs

Loading...

chronik/chronik-plugin-impl/src/module.rs

Loading...

chronik/chronik-plugin-impl/src/token.py

Loading...

chronik/chronik-plugin-impl/src/token.rs

Loading...

chronik/chronik-plugin-impl/src/tx.py

Loading...

chronik/chronik-plugin-impl/src/tx.rs

Loading...

chronik/chronik-plugin-impl/tests/test_tx_to_py.py

Loading...

modules/ecash-agora/agora.py

Loading...