[ecash-herald] Give Cashtab XEC rewards their own line
ClosedPublic
Actions

Authored by bytesofman on Oct 2 2024, 22:22.

Details

Reviewers

emack
Fabien

Group Reviewers

Restricted Project

Commits

rABCbe3341096d86: [ecash-herald] Give Cashtab XEC rewards their own line

Summary

These txs are currently listed like any other XEC tx. Pull them out of that list, where the info is not newsworthy, and instead include interesting info about these txs.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-track-xec-faucet

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30480
Build 60478: Build Diff	ecash-herald-tests
Build 60477: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 2 2024, 22:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2024, 22:22

bytesofman published this revision for review.Oct 2 2024, 22:23

Harbormaster completed remote builds in B30480: Diff 49916.Oct 2 2024, 22:24

emack requested changes to this revision.Oct 3 2024, 00:24

emack added a subscriber: emack.

emack added inline comments.

apps/ecash-herald/src/parse.js
1412	aren't we to use `BigInt` for utxo value calculations going forward?

This revision now requires changes to proceed.Oct 3 2024, 00:24

bytesofman requested review of this revision.Oct 3 2024, 04:57

bytesofman marked an inline comment as done.

bytesofman added inline comments.

apps/ecash-herald/src/parse.js
1412	in this case -- we are only dealing with satoshis (i.e. integers that are never to exceed Number.MAX_SAFE_INTEGER) and addition. so there's no need for BigInt.