Paths

Table of Contentst

Differential D16856

[ecash-herald] Better presentation of Cashtab rewards
ClosedPublic
Actions

Authored by bytesofman on Oct 3 2024, 22:37.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC74f745865b0e: [ecash-herald] Better presentation of Cashtab rewards

Summary

Combine token and cachet reward summaries into the same section. Include a Cashtab header that links to Cashtab.

Test Plan

npm test, review screenshots

Before:

After:

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-better-format-cashtab

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30496
Build 60509: Build Diff	ecash-herald-tests
Build 60508: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 3 2024, 22:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2024, 22:37

bytesofman published this revision for review.Oct 3 2024, 22:38

bytesofman edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B30496: Diff 49945.Oct 3 2024, 22:39

Unrelated to the diff: in the second screenshot there seems to be an issue with the BTC price

This revision is now accepted and ready to land.Oct 4 2024, 07:37

In D16856#382403, @PiRK wrote:

Unrelated to the diff: in the second screenshot there seems to be an issue with the BTC price

For the test mock msgs, the API data is mocked at constant prices.

Closed by commit rABC74f745865b0e: [ecash-herald] Better presentation of Cashtab rewards (authored by bytesofman). · Explain WhyOct 4 2024, 16:02

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC74f745865b0e: [ecash-herald] Better presentation of Cashtab rewards.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

54 lines

test/

mocks/

block.js

2 lines

Diff 49945

View Options

apps/ecash-herald/src/parse.js