Page MenuHomePhabricator
Differential D16856

[ecash-herald] Better presentation of Cashtab rewards
ClosedPublic
Actions

Authored by bytesofman on Oct 3 2024, 22:37.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC74f745865b0e: [ecash-herald] Better presentation of Cashtab rewards
Summary

Combine token and cachet reward summaries into the same section. Include a Cashtab header that links to Cashtab.

Test Plan

npm test, review screenshots

Before:

image.png (460×577 px, 73 KB)

After:

image.png (460×577 px, 69 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Oct 3 2024, 22:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2024, 22:37
bytesofman published this revision for review.Oct 3 2024, 22:38
bytesofman edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B30496: Diff 49945.Oct 3 2024, 22:39
PiRK accepted this revision.Oct 4 2024, 07:37
PiRK added a subscriber: PiRK.

Unrelated to the diff: in the second screenshot there seems to be an issue with the BTC price

This revision is now accepted and ready to land.Oct 4 2024, 07:37
bytesofman added a comment.Oct 4 2024, 16:02
In D16856#382403, @PiRK wrote:

Unrelated to the diff: in the second screenshot there seems to be an issue with the BTC price

For the test mock msgs, the API data is mocked at constant prices.

Closed by commit rABC74f745865b0e: [ecash-herald] Better presentation of Cashtab rewards (authored by bytesofman). · Explain WhyOct 4 2024, 16:02
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC74f745865b0e: [ecash-herald] Better presentation of Cashtab rewards.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
src/
54 lines
test/
mocks/
2 lines

Diff 49949

View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/test/mocks/block.js

Loading...