Page MenuHomePhabricator
Differential D16906

[ecash-herald] Stop handling block connected event
ClosedPublic
Actions

Authored by bytesofman on Oct 14 2024, 16:18.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC29ca08179cc6: [ecash-herald] Stop handling block connected event
Summary

Now that we build more helpful messages for blocks that are invalidated by avalanche, stop "guessing" that blocks have a problem if they are connected by not finalized after an arbitrary amount of time.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-no-timeouts
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30587
Build 60690: Build Diffecash-herald-tests
Build 60689: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 14 2024, 16:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2024, 16:18
Harbormaster completed remote builds in B30586: Diff 50081.Oct 14 2024, 16:20
bytesofman updated this revision to Diff 50082.Oct 14 2024, 16:22

update cache ttl

bytesofman published this revision for review.Oct 14 2024, 16:23
Harbormaster completed remote builds in B30587: Diff 50082.Oct 14 2024, 16:24
Fabien requested changes to this revision.Oct 14 2024, 20:22
Fabien added a subscriber: Fabien.

For the next follow-up: you can remove the memoryCache entry for the block status as well as it's no longer needed

apps/ecash-herald/config.js
7

I would increase it a bit, like 4 hours so we handle even long time with no block

apps/ecash-herald/src/main.js
16

You don't need the 2x here

This revision now requires changes to proceed.Oct 14 2024, 20:22
bytesofman updated this revision to Diff 50092.Oct 14 2024, 20:34
bytesofman marked an inline comment as done.

no need to cache blk_invalidated, remove '2*' factor for ttl

Harbormaster completed remote builds in B30594: Diff 50092.Oct 14 2024, 20:36
Fabien accepted this revision.Oct 14 2024, 20:55
This revision is now accepted and ready to land.Oct 14 2024, 20:55
Closed by commit rABC29ca08179cc6: [ecash-herald] Stop handling block connected event (authored by bytesofman). · Explain WhyOct 14 2024, 21:15
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC29ca08179cc6: [ecash-herald] Stop handling block connected event.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
2 lines
src/
16 lines
59 lines
8 lines
test/
2 lines
53 lines

Diff 50082

View Options

apps/ecash-herald/config.js

Loading...
View Options

apps/ecash-herald/src/chronikWsHandler.js

Loading...
View Options

apps/ecash-herald/src/events.js

Loading...
View Options

apps/ecash-herald/src/main.js

Loading...
View Options

apps/ecash-herald/test/chronikWsHandler.test.js

Loading...
View Options

apps/ecash-herald/test/events.test.js

Loading...