[ecash-herald] Patch bug in daily summary calc
ClosedPublic
Actions

Authored by bytesofman on Sun, Oct 20, 02:55.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC6f457b103ee2: [ecash-herald] Patch bug in daily summary calc

Summary

Typo resulting in getting last 48 hrs worth of blocks instead of 24, patch

The checker was working, but bc I was mixing up "yesterday" with "today" -- was passing "yesterday" into getAllBlockTxs, which then had to go back in time well more than 144 blocks to get the "right" (wrong) block.

Test Plan

npm test, confirm typo corrected and the "right" date is going into getAllBlockTxs

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-summary-bug-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30695
Build 60906: Build Diff	ecash-herald-tests
Build 60905: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sun, Oct 20, 02:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Oct 20, 02:55

back out debug condition change

bytesofman published this revision for review.Sun, Oct 20, 02:56

Harbormaster completed remote builds in B30695: Diff 50229.Sun, Oct 20, 02:57

Harbormaster completed remote builds in B30696: Diff 50230.

emack accepted this revision.Sun, Oct 20, 06:06

This revision is now accepted and ready to land.Sun, Oct 20, 06:06

Closed by commit rABC6f457b103ee2: [ecash-herald] Patch bug in daily summary calc (authored by bytesofman). · Explain WhySun, Oct 20, 10:10

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC6f457b103ee2: [ecash-herald] Patch bug in daily summary calc.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

events.js

6 lines

Diff 50229

View Options

apps/ecash-herald/src/events.js

[ecash-herald] Patch bug in daily summary calcClosedPublicActions