Page MenuHomePhabricator
Differential D16957

[secp256k1] Add `secp256k1_ec_pubkey_cmp` and `secp256k1_xonly_pubkey_cmp`
ClosedPublic
Actions

Authored by tobias_ruck on Oct 22 2024, 17:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf5e54cd88989: [secp256k1] Add `secp256k1_ec_pubkey_cmp` and `secp256k1_xonly_pubkey_cmp`
Summary

Allows comparing secp256k1_pubkey and secp256k1_xonly_pubkey respectively, to establish an order between them.

This is a backport of secp256k1#850 and secp256k1#926.

We need this for porting rust-secp256k1 to the secp256k1 library of this repo.

Test Plan

ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Oct 22 2024, 17:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2024, 17:27
teamcity edited the summary of this revision. (Show Details)Oct 22 2024, 17:27
tobias_ruck edited the summary of this revision. (Show Details)Oct 22 2024, 17:27
tobias_ruck edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B30738: Diff 50284.Oct 22 2024, 17:46
tobias_ruck added a child revision: D16958: [secp256k1] Backport "Schnorrsig API overhaul".Oct 22 2024, 17:48
tobias_ruck published this revision for review.Oct 22 2024, 17:49
tobias_ruck updated this revision to Diff 50288.Oct 22 2024, 19:25

also backport secp256k1#926 too

tobias_ruck edited the summary of this revision. (Show Details)Oct 22 2024, 19:26
Fabien accepted this revision.Oct 22 2024, 19:28
This revision is now accepted and ready to land.Oct 22 2024, 19:28
Harbormaster completed remote builds in B30742: Diff 50288.Oct 22 2024, 19:40
Closed by commit rABCf5e54cd88989: [secp256k1] Add `secp256k1_ec_pubkey_cmp` and `secp256k1_xonly_pubkey_cmp` (authored by tobias_ruck). · Explain WhyOct 22 2024, 19:44
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCf5e54cd88989: [secp256k1] Add `secp256k1_ec_pubkey_cmp` and `secp256k1_xonly_pubkey_cmp`.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
include/
24 lines
21 lines
src/
modules/
extrakeys/
26 lines
38 lines
26 lines
50 lines

Diff 50289

View Options

src/secp256k1/include/secp256k1.h

Loading...
View Options

src/secp256k1/include/secp256k1_extrakeys.h

Loading...
View Options

src/secp256k1/src/modules/extrakeys/main_impl.h

Loading...
View Options

src/secp256k1/src/modules/extrakeys/tests_impl.h

Loading...
View Options

src/secp256k1/src/secp256k1.c

Loading...
View Options

src/secp256k1/src/tests.c

Loading...