Page MenuHomePhabricator

[Cashtab] Patch cancel vs buy distinction in agora partials
ClosedPublic

Authored by bytesofman on Oct 25 2024, 03:44.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCd20281f7a04d: [Cashtab] Patch cancel vs buy distinction in agora partials
Summary

Realized previous mock was wrong after testing some cancels. Seems like the isCanceled check is only for ONESHOT, need a better check for partials.

The check here is from guess and check, test driven. Works without breaking previous tests, except for one previous test that actually was a cancel, and should be broken.

Test Plan

npm test, see screenshots

patches bought amount for agora buys (before this diff, rendered as "bought 50")
before:

image.png (196×458 px, 23 KB)

after:
image.png (202×470 px, 24 KB)

patches cancels previously mis-parsed as buys
before:

image.png (175×450 px, 22 KB)

after:
image.png (186×469 px, 18 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
more-partialtx-fixing
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30829
Build 61171: Build Diffcashtab-tests
Build 61170: arc lint + arc unit