Page MenuHomePhabricator
Differential D1699

[qt] Add use available balance in send coins dialog
ClosedPublic
Actions

Authored by schancel on Aug 26 2018, 19:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING17962b1004a3: [qt] Add use available balance in send coins dialog
rABC17962b1004a3: [qt] Add use available balance in send coins dialog
Summary

Backport of Core PR #11316. (Commit d052e38)

Test Plan
make VERBOSE=1 check

Then test the gui.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1699
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3341
Build 4765: Bitcoin ABC Buildbot (legacy)
Build 4764: arc lint + arc unit

Event Timeline

schancel created this revision.Aug 26 2018, 19:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2018, 19:53
teamcity added a subscriber: teamcity.Aug 26 2018, 19:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3159: Diff 4699!Aug 26 2018, 20:30
teamcity added a comment.Aug 26 2018, 20:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

jasonbcox added a subscriber: jasonbcox.Aug 27 2018, 05:51

I'm ready to green this pending investigation on that failing test. I see it failing on some other diffs, so I imagine this change didn't affect it.

deadalnix requested changes to this revision.Sep 10 2018, 14:31
deadalnix added a subscriber: deadalnix.

See why test fail.

This revision now requires changes to proceed.Sep 10 2018, 14:31
schancel added a comment.Sep 10 2018, 15:52

I already fixed the test. This just needs a rebase.

schancel updated this revision to Diff 4855.Sep 10 2018, 21:34

Rebase

teamcity added a comment.Sep 10 2018, 21:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 10 2018, 22:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3255: Diff 4855!Sep 10 2018, 22:02
deadalnix requested changes to this revision.Sep 10 2018, 22:13

This doesn't build.

This revision now requires changes to proceed.Sep 10 2018, 22:13
schancel updated this revision to Diff 4993.Sep 22 2018, 22:26

Update for Amount::zero() change

teamcity added a comment.Sep 22 2018, 22:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 22 2018, 23:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3341: Diff 4993.Sep 22 2018, 23:04
deadalnix accepted this revision.Sep 24 2018, 07:00
This revision is now accepted and ready to land.Sep 24 2018, 07:00
Closed by commit rABC17962b1004a3: [qt] Add use available balance in send coins dialog (authored by CryptAxe <cryptaxe@gmail.com>, committed by schancel). · Explain WhySep 24 2018, 17:06
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4993

View Options

src/qt/forms/sendcoinsentry.ui

Loading...
View Options

src/qt/sendcoinsdialog.h

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/qt/sendcoinsentry.h

Loading...
View Options

src/qt/sendcoinsentry.cpp

Loading...